Skip to content

Output Config Option Values in Canonical Case#58735

Closed
graphemecluster wants to merge 1 commit intomicrosoft:mainfrom
graphemecluster:cased-config-values
Closed

Output Config Option Values in Canonical Case#58735
graphemecluster wants to merge 1 commit intomicrosoft:mainfrom
graphemecluster:cased-config-values

Conversation

@graphemecluster
Copy link
Copy Markdown
Contributor

This aligns the letter cases of the values in tsconfig.jsons generated by tsc --init and some diagnostics (e.g. TS1501, TS6046) with the autocomplete values provided to tsconfig.json in VSCode and other diagnostics with hard-coded target versions.
This should not affect anything related to value parsing.

Addresses #55600 (comment).

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 2, 2024
@typescript-bot
Copy link
Copy Markdown
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey
Copy link
Copy Markdown
Member

For ecmascript versions I can sort of understand it, but I'm not totally convinced we consider "Node16" more canonical than "node16", "Preserve" etc, https://www.typescriptlang.org/tsconfig/#module

And so on.

@graphemecluster
Copy link
Copy Markdown
Contributor Author

I don’t know, I just completely sticked to the autocompletions provided by VSCode (except for a few subtle inconsistencies of lib values, which should be fixed in VSCode). So perhaps changes to the values should be made on the VSCode side synchronically.

@jakebailey
Copy link
Copy Markdown
Member

The autocompletions in VS Code are just the ones from schemastore. Not sure any of us like those either 😄

@graphemecluster
Copy link
Copy Markdown
Contributor Author

Oh, I see. Wonder why we didn’t maintain one here or in the VSCode repo.
Anyway, may you give me a list of what should be kept and what should be discarded once there is a consensus on the letter cases? Do you prefer camel case to Pascal case?

@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants