Partially revert #41044, restoring parameter destructurings in d.ts files#50779
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Sep 15, 2022
Merged
Partially revert #41044, restoring parameter destructurings in d.ts files#50779jakebailey merged 2 commits intomicrosoft:mainfrom
jakebailey merged 2 commits intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50707 (at least to the extent that we have the pre-4.8 behavior).
In a followup PR, I can remove these destructurings/bindings/whatevertheyrecalleds in the declaration emitter.
Note that the new errors added in #41044 remain. I guess the PR had two somewhat-related changes in it?