[master] [All-e]Fixed asset report 5607 and 4413 showing different results with Declining Balance#8324
Merged
Conversation
github-actions
Bot
added
AL: Apps (W1)
…-5607-and-4413-showing-different-results
…g-different-results' of https://github.com/neeleshsinghal/BCApps into bugs/Bug-636727-Fixed-asset-report-5607-and-4413-showing-different-results
…-5607-and-4413-showing-different-results
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
djukicmilica
previously approved these changes
May 28, 2026
AleksanderGladkov
requested changes
May 28, 2026
Contributor
AleksanderGladkov
left a comment
AleksanderGladkov
left a comment
There was a problem hiding this comment.
@neeleshsinghal please also add description to the PR
Contributor
|
AleksanderGladkov
approved these changes
Jun 2, 2026
djukicmilica
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workitem :
Bug 636727: [master] [All-e]Fixed asset report 5607 and 4413 showing different results with Declining Balance
Fixes AB#636727
Issue: Report 4413 (Fixed Asset Projected Value Excel) calculates incorrect depreciation amounts for Declining Balance assets when projections cross a fiscal year boundary, producing different results than the legacy Report 5607.
Cause: In InsertProjectedEntries, EntryAmounts[3] (depreciation in fiscal year) was reset to 0 before accumulating the current period's depreciation, causing the last fiscal period's depreciation to spill into the new fiscal year and shifting the effective book value base back one month.
Solution: Moved AccumulateProjectionEntryAmounts before the fiscal year boundary reset (EntryAmounts[3] := 0) so the outgoing fiscal year's final depreciation is fully accumulated before the counter resets, matching the order used in Report 5607.