[Shopify] Skip empty inventory API call when batch size is exact multiple of 250#7214
Merged
Conversation
…iple of 250 Guard the final ExecuteInventoryGraphQL call with an InputSize > 0 check to avoid sending an unnecessary empty request when the number of items is an exact multiple of the 250-item batch size. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Clear LastGraphQLRequest in SetRetryScenario to prevent stale values from a previous test leaking into the next test. Update assertion to expect no GraphQL request when stock is equal and ForceExport is false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
darjoo
approved these changes
Mar 23, 2026
…625960-empty-inventory-request
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Shopify-Connector-Test: 0% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
Groenbech96
approved these changes
Mar 26, 2026
onbuyuka
added a commit
that referenced
this pull request
Mar 26, 2026
Resolve conflict in ShpfyInventoryAPI.Codeunit.al: keep main's InputSize > 0 guard (from #7214) with branch's ExpectedCost parameter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteInventoryGraphQLcall inExportStockwithif InputSize > 0to avoid sending an unnecessary empty request when the number of inventory items is an exact multiple of the 250-item batch sizeFixes AB#625960
🤖 Generated with Claude Code