Skip to content

[Bug]: "Vend. Entry-Edit" wrong Event, not the same as in "Cust. Entry-Edit" (Latest BC Insider W1 29.0.50796.0) #8316

@Lucaa2k

Description

@Lucaa2k

Describe the issue

Its about this Event in codeunit 113 "Vend. Entry-Edit" (Latest BC Insider W1 29.0.50796.0)

    [IntegrationEvent(false, false)]
    local procedure OnRunOnAfterVendLedgEntryMofidy(var VendorLedgerEntry: Record "Vendor Ledger Entry")
    begin
    end;

First of the Name is Misspelled (Should be Modify not Mofidy)

But the worst part is the Functionality.
For Comparison this is the counterpart on the Customer:

codeunit 103 "Cust. Entry-Edit"

    /// <summary>
    /// Raised after the customer ledger entry has been modified.
    /// </summary>
    /// <param name="CustLedgerEntryRec">The customer ledger entry record passed to the codeunit.</param>
    /// <param name="CustLedgerEntry">The modified customer ledger entry.</param>
    [IntegrationEvent(false, false)]
    local procedure OnRunOnAfterCustLedgEntryModify(var CustLedgerEntryRec: Record "Cust. Ledger Entry"; var CustLedgerEntry: Record "Cust. Ledger Entry")
    begin
    end;

As you can see it includes the Parameter of the Entry Rec instead of just the Entry, also the XML Documentation is missing.

And since its used after the Modification of the Rec its quite Important.

Expected behavior

It should be copied from the "Cust. Entry-Edit" Codeunit so:

    /// <summary>
    /// Raised after the vendor ledger entry has been modified.
    /// </summary>
    /// <param name="VendLedgerEntryRec">The vendor ledger entry record passed to the codeunit.</param>
    /// <param name="VendLedgerEntry">The modified vendor ledger entry.</param>
    [IntegrationEvent(false, false)]
    local procedure OnRunOnAfterVendLedgEntryModify(var VendLedgerEntryRec: Record "Vendor Ledger Entry"; var VendLedgerEntry: Record "Vendor Ledger Entry")
    begin
    end;

and in the OnRun Trigger where its called:

        VendLedgEntry.Modify();
        OnRunOnAfterVendLedgEntryMofidy(Rec, VendLedgEntry);
        Rec := VendLedgEntry;

Steps to reproduce

Not needed

Additional context

No response

I will provide a fix for a bug

  • I will provide a fix for a bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    IntegrationGitHub request for Integration area

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions