Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
…elopeCreator
The RequestEnvelopeCreator function was incorrectly passing RequestDataType
(="RequestData") as the envelope type to _createEnvelope. This caused the
envelope name to be set to "RequestData" instead of the correct value
"Microsoft.ApplicationInsights.{0}.Request" which gets resolved to
"Microsoft.ApplicationInsights.[ikey].Request" when processed.
This bug matches the same pattern as DependencyEnvelopeCreator, which
correctly uses RemoteDependencyEnvelopeType.
Agent-Logs-Url: https://github.com/microsoft/ApplicationInsights-JS/sessions/b0c7586e-a66a-48c6-8fc1-59421404eba6
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Copilot
AI
changed the title
[WIP] Fix event name for RequestData spans
fix: RequestEnvelopeCreator sends "RequestData" as envelope name instead of "Microsoft.ApplicationInsights.{ikey}.Request"
Apr 13, 2026
MSNev
approved these changes
Apr 13, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes outgoing Request telemetry envelopes so the Breeze event name (IEnvelope.name) uses the correct Request envelope type (Microsoft.ApplicationInsights.{ikey}.Request) instead of incorrectly using the inner data type (RequestData).
Changes:
- Import
RequestEnvelopeTypefrom./Telemetry/RequestData. - Update
RequestEnvelopeCreatorto passRequestEnvelopeTypeinto_createEnvelopewhile still usingRequestDataTypefor_createData.
rads-1996
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestEnvelopeCreatorwas passingRequestDataType("RequestData") as theenvelopeTypeto_createEnvelopeinstead ofRequestEnvelopeType("Microsoft.ApplicationInsights.{0}.Request"). This caused the IEnvelopenamefield — the event name sent to the Breeze endpoint — to be"RequestData"rather than the expected"Microsoft.ApplicationInsights.<ikey>.Request".Change
EnvelopeCreator.ts: ImportRequestEnvelopeTypefrom./Telemetry/RequestDataand pass it to_createEnvelopeinRequestEnvelopeCreator, consistent with howDependencyEnvelopeCreatorusesRemoteDependencyEnvelopeType.RequestDataTypeis still correctly used for the inner_createDatacall (thebaseTypefield of the data wrapper); only the outer envelope name is affected by this fix.