This repository was archived by the owner on Jan 13, 2023. It is now read-only.
FIX Screenshot file path under windows#243
Open
glafarge wants to merge 1 commit intomichenriksen:masterfrom
Open
FIX Screenshot file path under windows#243glafarge wants to merge 1 commit intomichenriksen:masterfrom
glafarge wants to merge 1 commit intomichenriksen:masterfrom
Conversation
As the screenshot file was relative to chrome folder when calling chrome.exe, screenshots couldn't be created on unexisting folder. This commit resolve the issue by passing outDirectory absolute path to chrome executable and add a log output to help diagnose errors. Fixes many issues for users that couldn't make screenshots successfully.
shelld3v
approved these changes
Feb 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the screenshot file was relative to chrome folder when calling chrome.exe, screenshots couldn't be created on unexisting folder.
This commit resolve the issue by passing outDirectory absolute path to chrome executable and add a log output to help diagnose errors.
Fixes many issues for users that couldn't make screenshots successfully.