Skip to content

Support for Jackson 3#685

Draft
cigaly wants to merge 2 commits intomaxmind:mainfrom
cigaly:jackson3
Draft

Support for Jackson 3#685
cigaly wants to merge 2 commits intomaxmind:mainfrom
cigaly:jackson3

Conversation

@cigaly
Copy link
Copy Markdown

@cigaly cigaly commented Mar 30, 2026

Here is support for Jackson 3. All tests are passing, so this may be used as staring point.

@cigaly cigaly mentioned this pull request Mar 30, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project from Jackson 2.x to 3.0.0, involving updates to dependencies, package names, and exception handling logic across the codebase. The reviewer identifies a consistent issue regarding the use of the tools.jackson namespace, noting that official Jackson 3.x artifacts should maintain the com.fasterxml.jackson group ID and package names. Actionable suggestions were provided for all affected files, including the build configuration, module descriptors, and source files, to revert these namespace changes and ensure alignment with official releases.

@cigaly
Copy link
Copy Markdown
Author

cigaly commented Mar 30, 2026

Code Review

This pull request migrates the project from Jackson 2.x to 3.0.0, involving updates to dependencies, package names, and exception handling logic across the codebase. The reviewer identifies a consistent issue regarding the use of the tools.jackson namespace, noting that official Jackson 3.x artifacts should maintain the com.fasterxml.jackson group ID and package names. Actionable suggestions were provided for all affected files, including the build configuration, module descriptors, and source files, to revert these namespace changes and ensure alignment with official releases.

This is complete nonsense since there are no version 3 in com.fasterxml.jackson˛hierarchy, besides com.fasterxml.jackson.annotation

So, please, do not ask me why I am saying that AI is for "Artificial Idiotism"

@horgh
Copy link
Copy Markdown
Contributor

horgh commented Mar 30, 2026

Thank you! I think we will want to wait on us doing a major version bump in this project before we do this upgrade. I don't think we're ready to do that at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants