Disable packet tagging on MingW by default, fix TLS qualifier

[jclc]

Added back netcode_enable_packet_tagging() even when NETCODE_PACKET_TAGGING=0 because otherwise code calling it (Yojimbo) would not compile.

[gafferongames]

Thank you! ps. To make sure netcode keeps working with MingW do you think you could modify the GitHub actions script to have a build in MingW test? This way the work you have done will get locked in and keep working even when other people make changes.

[jclc]

I can check that out, but I'm not at all familiar with GitHub actions.

[gafferongames]

They're pretty simple. They are defined here:

https://github.com/mas-bandwidth/netcode/tree/main/.github/workflows/ci.yml

[jclc]

Could you let me know if this makes any sense? Let's say I add the following after the vs2019 steps:

    # Set up msys2/MingW-w64 toolchain
    - name: Setup (msys2)
      if: runner.os == 'Windows'
      uses: msys2/setup-msys2@v2

    - name: Build (msys2)
      if: runner.os == 'Windows'
      run: |
        premake5 gmake
        make config=${{ matrix.configuration }}

    - name: Test (msys2)
      if: runner.os == 'Windows'
      run: "& ./bin/test.exe"

Or should this be made an entirely separate job? Also, can I run the pipelines on my fork to test this?

[gafferongames]

Yes it should be a separate job You can fork and test it there in your fork for free then make a PRSent from my iPhoneOn Jan 27, 2025, at 7:55 AM, jclc ***@***.***> wrote: Could you let me know if this makes any sense? Let's say I add the following after the vs2019 steps: # Set up msys2/MingW-w64 toolchain - name: Setup (msys2) if: runner.os == 'Windows' uses: ***@***.*** - name: Build (msys2) if: runner.os == 'Windows' run: | premake5 gmake make config=${{ matrix.configuration }} - name: Test (msys2) if: runner.os == 'Windows' run: "& ./bin/test.exe" Or should this be made an entirely separate job? Also, can I run the pipelines on my fork to test this? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

[gafferongames]

Almost there!

[jclc]

Sorry about the spam. I don't have a local msys2 environment available so I can't really run these locally.

All that's missing is linking to ws2_32 and IPHLPAPI. I've never used premake before, could you tell me how to do this only when compiler is MingW (or target is Windows but compiler is not MSVC)?

[jclc]

Okay the workflow passes now. Sorry for the spam again.

[gafferongames]

No problem at all!

[gafferongames]

Woo!