Skip to content

API for returning extra items returned by render server#87

Merged
markfinger merged 3 commits into
markfinger:masterfrom
sassanh:master
Jul 17, 2018
Merged

API for returning extra items returned by render server#87
markfinger merged 3 commits into
markfinger:masterfrom
sassanh:master

Conversation

@sassanh

@sassanh sassanh commented Jul 16, 2018

Copy link
Copy Markdown
Contributor

This is required to be able to use things like react-helmet.

@markfinger

Copy link
Copy Markdown
Owner

Thanks for that, it's a good idea.

Given the extra property is actually the output of the render server, the name "extra" seems a bit confusing in this context. Do you mind changing the extra variable&property to data?

If you can also update the docs (README.md) to add the property in https://github.com/markfinger/python-react#basic-usage, that'd be great.

@sassanh

sassanh commented Jul 16, 2018

Copy link
Copy Markdown
Contributor Author

Sure, will do asap.

@sassanh

sassanh commented Jul 16, 2018

Copy link
Copy Markdown
Contributor Author

@markfinger OK, I changed the variable name and added the api to the README.md.

@markfinger markfinger merged commit 0e24aa3 into markfinger:master Jul 17, 2018
@markfinger

Copy link
Copy Markdown
Owner

Cool, looks good.

Thanks, @sassanh 😄

@markfinger

Copy link
Copy Markdown
Owner

I've published your changes to PyPI as react==4.2.0. Let me know if you run into any issues, but otherwise thanks again for the PR.

@markfinger

Copy link
Copy Markdown
Owner

Just noticed a bug when RENDER = False.

react==4.2.1 includes a fix.

@sassanh

sassanh commented Jul 17, 2018

Copy link
Copy Markdown
Contributor Author

Great, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants