enhancements in mapbender_user application for version 5#170
Open
astroidex wants to merge 1 commit into
Open
Conversation
Member
astroidex
commented
May 8, 2026
astroidex
commented
- first changes to support all new elements in mapbender_user application
- can be used for further testing
Phocacius
requested changes
May 12, 2026
| wmsloader: | ||
| class: Mapbender\WmsBundle\Element\WmsLoader | ||
| target: map | ||
|
|
Member
There was a problem hiding this comment.
please remove the empty lines (for all spacing within element definitions, not just here)
| interactivehelp: | ||
| class: Mapbender\CoreBundle\Element\InteractiveHelp | ||
| screenType: desktop | ||
| autopen: true |
Member
There was a problem hiding this comment.
Suggested change
| autopen: true | |
| autoOpen: true |
typo: an o is missing. Up for discussion: Maybe set autoOpen to false (and make it triggerable via button in the toolbar)? It might be a bit annoying when it opens everytime in the demo app.
| element_icon: iconPrint | ||
| placeholder: mb.demoapps.search | ||
| class: Mapbender\CoreBundle\Element\SimpleSearch | ||
| query_url: https://osm-photon-search.wheregroup.com/search/api?limit=20&lat=50.7163&lon=7.1366&osm_tag=!railway&osm_tag=!highway:elevator&osm_tag=!tourism&osm_tag=!amenity |
Member
There was a problem hiding this comment.
the hardcoded lat/lon feels wrong to me. This might be a feature request, but is there already a possibility to add the current viewport as simple search parameters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.