Support sandbox and bulk modes#12
Merged
andrii-porokhnavets merged 2 commits intomainfrom May 5, 2025
Merged
Conversation
andrii-porokhnavets
force-pushed
the
support-sandbox-env
branch
from
81be95d to
326b5e3
Compare
andrii-porokhnavets
changed the title
sebaszap123-dev
left a comment
sebaszap123-dev
left a comment
There was a problem hiding this comment.
Looks good overall! Just suggested improving the _host logic to make it more flexible and future-proof in case the sandbox host changes or needs to be overridden. Also added an exception to clarify errors when inbox_id is missing in sandbox mode. Great work so far!
Comment on lines
+72
to
+79
| @property | ||
| def _host(self) -> str: | ||
| if self.api_host: | ||
| return self.api_host | ||
| if self.sandbox: | ||
| return self.SANDBOX_HOST | ||
| if self.bulk: | ||
| return self.BULK_HOST | ||
| return self.DEFAULT_HOST | ||
|
|
There was a problem hiding this comment.
We should find a way to make it more flexible for future changes—hopefully unnecessary—but what if the sandbox host changes? In that case, we wouldn’t be able to handle it.
Suggested change
| @property | |
| def _host(self) -> str: | |
| if self.api_host: | |
| return self.api_host | |
| if self.sandbox: | |
| return self.SANDBOX_HOST | |
| if self.bulk: | |
| return self.BULK_HOST | |
| return self.DEFAULT_HOST | |
| @property | |
| def _host(self) -> str: | |
| if self.api_host and self.sandbox: | |
| return self.api_host | |
| if self.api_host and self.bulk: | |
| return self.api_host | |
| if self.sandbox: | |
| return self.SANDBOX_HOST | |
| if self.bulk: | |
| return self.BULK_HOST | |
| if self.api_host: | |
| return self.api_host | |
| return self.DEFAULT_HOST | |
Contributor
Author
There was a problem hiding this comment.
It's doubtful that the host will be changed, but the client supports api_host, which has the highest priority and always takes part of the API URL if it's present, regardless of other parameters.
Introduced `sandbox` mode, allowing configuration for sandbox environments via `inbox_id`. Implemented validation to ensure correct usage of `sandbox` and `inbox_id`, along with related tests. Updated URL generation logic and error handling for enhanced flexibility.
Introduce a new `bulk` mode in the Mailtrap client, setting a dedicated `BULK_HOST` for bulk operations. Updated validation logic to prevent conflicts between bulk and sandbox modes. Added corresponding test cases to ensure correct functionality and URL generation.
andrii-porokhnavets
force-pushed
the
support-sandbox-env
branch
from
326b5e3 to
a138158
Compare
andrii-porokhnavets
changed the base branch from
main
to
deprecate-dead-python-versions
andrii-porokhnavets
requested review from
a team,
VladimirTaytor and
leonid-shevtsov
leonid-shevtsov
approved these changes
May 1, 2025
mklocek
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bulkandsanboxmodes. This PR introduces this functionalityChanges
sanboxmode support in MailtrapClientinbox_idparameter to be setbulkmode support in MailtrapClientHow to test
bulk=True)sandbox=True, inbox_id=123)