fix: show certificate expiry on status page for TCP monitors#6984
Merged
CommanderStorm merged 2 commits intolouislam:masterfrom Feb 19, 2026
Merged
Conversation
The certificate expiry indicator on status pages was only shown for HTTP-based monitors (http, keyword, json-query with https). TCP port monitors using SSL/TLS also store TLS certificate info via handleTlsInfo, but the status page didn't display it because toPublicJSON filtered by monitor type. Remove the type check so getCertExpiry is called for any monitor when certificate expiry display is enabled. Monitors without TLS info simply return empty data. Fixes louislam#6958
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where TCP port monitors with SSL/TLS connections were not displaying certificate expiry indicators on status pages, even though they store certificate information in the database.
Changes:
- Removed the monitor type restriction in
toPublicJSONthat prevented non-HTTP monitors from displaying certificate expiry information on status pages
CommanderStorm
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate expiry indicator on status pages was only shown for HTTP-based monitors (
http,keyword,json-querywith HTTPS). TCP port monitors using SSL/TLS also store TLS certificate info viahandleTlsInfo, but the status page didn't display it becausetoPublicJSONfiltered by monitor type.This removes the type restriction so
getCertExpiryis called for any monitor when certificate expiry display is enabled. Monitors without TLS info simply return empty data (validCert: false), so there's no functional change for non-TLS monitors.Fixes #6958