Add ability to publish h265 bytestream via tcp or unix socket#722
Merged
chenosaurus merged 4 commits intomainfrom Jan 12, 2026
Merged
Add ability to publish h265 bytestream via tcp or unix socket#722chenosaurus merged 4 commits intomainfrom
chenosaurus merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the simulcast functionality to support H.265/HEVC codec in addition to the existing H.264 support. Users can now publish H.265 video streams using the h265:// URL scheme and create simulcast tracks with multiple H.265 layers.
Key changes:
- Extended the simulcast URL regex to accept both
h264://andh265://protocols - Added codec validation to ensure all simulcast layers use the same codec (either all H.264 or all H.265)
- Updated documentation and usage strings to reflect H.265 support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/lk/room.go | Updated simulcast URL regex and validation logic to support both h264 and h265 codecs; added codec consistency checks |
| cmd/lk/join.go | Extended parseSimulcastURL, createSimulcastVideoTrack, and related functions to handle h265 codec; updated publishSocket to map h265 to the appropriate MIME type |
| cmd/lk/join_test.go | Added test cases for h265 URLs and updated test descriptions to reflect support for both codecs |
| README.md | Updated documentation to mention H.265/HEVC support and codec compatibility requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
remove redundant check Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
boks1971
approved these changes
Dec 19, 2025
xianshijing-lk
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h265://HOST:PORTto be used with the--publishflag to publish a pre-encoded h265 video stream.