Reserve generation suffix for child key derivation#193
Open
crossagent-production-app[bot] wants to merge 2 commits into
Open
Reserve generation suffix for child key derivation#193crossagent-production-app[bot] wants to merge 2 commits into
crossagent-production-app[bot] wants to merge 2 commits into
Conversation
Author
Delivery Evidence SummaryChange:
Objective Evidence:
Visual Evidence:
Reviewer:
Risks / Not Covered:
Generated at: 2026-06-04T12:38:21.796Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/litentry/agentKeys/issues/8\n\nSummary:\n- Adds generation-aware HDKD helpers that derive logical agent keys at /, with initial pairing fixed at generation 0.\n- Updates broker pairing claim/poll so child omni derivation and J1_agent derivation_path use //label/0 while storing the base label as the logical agent identity.\n- Documents the reserved /0, /1, /2 convention for future rotation without base-path recycling.\n\nVerification:\n- cargo fmt --check\n- cargo test -p agentkeys-core actor_omni\n- cargo test -p agentkeys-broker-server --test agent_bootstrap_flow full_request_claim_poll_pending_flow\n- cargo test -p agentkeys-broker-server --test agent_bootstrap_flow\n\n\nChange:\n- Initial child pairing now derives at //label/0 via generation-aware helpers, reserving /1, /2, ... for future same-agent rotation.\n- Broker poll exposes derivation_path //label/0 in the J1_agent response/JWT.\n- Architecture docs describe generation suffix semantics and keep base-label recycling disabled.\nObjective Evidence:\n- cargo fmt --check: passed\n- cargo test -p agentkeys-core actor_omni: passed (15 tests passed; includes generation suffix and rotation separation cases)\n- cargo test -p agentkeys-broker-server --test agent_bootstrap_flow full_request_claim_poll_pending_flow: passed\n- cargo test -p agentkeys-broker-server --test agent_bootstrap_flow: passed (5 tests passed)\nVisual Evidence:\n- n.a.\nReviewer:\n- Repo Intake Reviewer\nRisks / Not Covered:\n- No UI/browser behavior was changed, so screenshot evidence is not applicable.\n- Full rotation flow and on-chain current_generation storage are documented/reserved but not implemented in this smallest safe change.\n