Skip to content

mwifiex: rebase some patches#64

Merged
qzed merged 9 commits into
v5.8-surface-develfrom
mwifiex/rebase-patches
Oct 17, 2020
Merged

mwifiex: rebase some patches#64
qzed merged 9 commits into
v5.8-surface-develfrom
mwifiex/rebase-patches

Conversation

@kitakar5525
Copy link
Copy Markdown
Member

Hi, I slightly cleaned up mwifiex patches.

  1. revert some existing patches to improve changes and commit messages
  2. added improved patches

mwifiex: pcie: disable bridge_d3 for Surface gen4+
Changes from the previous patch:

  • Use recently added quirk implementation and apply for only Surface gen4+ devices
  • Moved to the bottom of probe() so that quirk implementation can init before use

mwifiex: add allow_ps_mode module parameter
Changes from the previous patch:

  • Use -EPERM instead of -1 for return value when enabling ps_mode is disallowed by modparam
  • changed allow_ps_mode modparam permission from 0444 to 0644 because it can be changed after probe as well
  • Simplified comment in code
  • Simplified print message

mwifiex: mwifiex: print message when changing ps_mode
Changes from the previous patch:

  • Simplified print messages

mwifiex: disable ps_mode explicitly by default instead
Changes from previous patch:

  • Squashed mwifiex: sta_cmd: add comment for not enabling ps_mode by default and mwifiex: sta_cmd: do not enable ps_mode by default
  • Disable ps_mode explicitly instead of just removing the code

Removing the code that enables ps_mode might be enough, but there's also
no reason not to explicitly disable it. So, let's disable it explicitly.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants