Skip to content

doc: Fix rustdoc warning about bare URL.#484

Merged
xStrom merged 1 commit into
linebender:mainfrom
waywardmonkeys:fix-bare-url-rustdoc-warning
Mar 1, 2024
Merged

doc: Fix rustdoc warning about bare URL.#484
xStrom merged 1 commit into
linebender:mainfrom
waywardmonkeys:fix-bare-url-rustdoc-warning

Conversation

@waywardmonkeys

Copy link
Copy Markdown
Collaborator

No description provided.

@DJMcNab DJMcNab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was trying to express in linebender/glazier#149 (comment)

I don't see any feasible solution other than maybe reporting these through a webhook on Zulip? That is kinda terrible UX though
Because these are nightly docs, we don't want it to break/block randomly for contributors

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

This is what I was trying to express in linebender/glazier#149 (comment)

I don't see any feasible solution other than maybe reporting these through a webhook on Zulip? That is kinda terrible UX though Because these are nightly docs, we don't want it to break/block randomly for contributors

I understand and share your frustration! I don't have an answer at the moment or I would have included it in this PR. :(

@DJMcNab

DJMcNab commented Mar 1, 2024

Copy link
Copy Markdown
Member

Yeah, no worries. I'm happy to get this landed though. I'll let you press the button

@xStrom

xStrom commented Mar 1, 2024

Copy link
Copy Markdown
Member

I'll add it to the queue just to make sure it won't miss the release train.

@xStrom xStrom added this pull request to the merge queue Mar 1, 2024
Merged via the queue into linebender:main with commit ba24b81 Mar 1, 2024
@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

@xStrom Thanks. I had a bunch of meetings and stuff and got lost.

@waywardmonkeys waywardmonkeys deleted the fix-bare-url-rustdoc-warning branch March 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants