Overhaul CI and add an MSRV#21
Merged
Merged
Conversation
Adds an MSRV, and adapts the CI from linebender/glazier#149
Philipp-M
approved these changes
Jan 30, 2024
| components: clippy | ||
|
|
||
| - name: cargo clippy (wasm) | ||
| run: cargo clippy --all-targets --target wasm32-unknown-unknown -- -D warnings |
Member
There was a problem hiding this comment.
Is --all-targets necessary here (when it is already done in other jobs?)?
Member
Author
There was a problem hiding this comment.
I think so.
This ensures that any tests, benchmarks and examples check for wasm (even though there currently are none of those)
This is cargo having two different meanings of the word "target" (or well at least three, if you include the target directory).
dfrg
approved these changes
Jan 31, 2024
dfrg
left a comment
dfrg
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an MSRV, and adapts the CI from linebender/glazier#149
Also prepares for merge queues