Improve CI#111
Conversation
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
These changes seem reasonable, although there is a bit of an explosion of jobs.
Do we really need to run clippy and testing both with and without accesskit?
waywardmonkeys
force-pushed
the
improve-ci
branch
3 times, most recently
from
bf18889 to
cd71d1c
Compare
|
@DJMcNab We need to skip the accesskit build when not on macOS or Windows, but handled that without job explosion. |
|
What happens on unix when accesskit is enabled? I struggle to foresee that failing to compile - it should just do nothing when run. If it fails to compile, that's a problem which needs fixing somewhat urgently - we should be encouraging consumers to enable the accesskit feature |
|
You can see the failures in a previous run: https://github.com/linebender/glazier/actions/runs/5486073995 It can certainly be fixed in a different / subsequent PR. |
`actions-rs` actions have been unmaintained for years and produce warnings when used as they trigger deprecation notices about functionality that GitHub will be removing.
`actions-rs` actions have been unmaintained for years and produce warnings when used as they trigger deprecation notices about functionality that GitHub will be removing.
This was a remnant of the `druid-shell` days and not needed here.
v1 produces warnings when used as it triggers deprecation notices about functionality that GitHub will be removing.
This checks that the accesskit feature compiles the library and the `accesskit` example. This only runs the tries to build it on macOS and Windows as `glazier` doesn't yet support `accesskit` elsewhere.
waywardmonkeys
force-pushed
the
improve-ci
branch
from
cd71d1c to
78911a9
Compare
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Thanks for pushing this forward!
I agree with the previous note that the accesskit example shouldn't have its own job, nor should it be limited in OS coverage. However I also agree with your assessment that resolving that should be followup work (and not necessarily by you). I'll create an issue to track it.
I think this is good to merge as is.
3 participants
This updates various CI actions to using current or maintained versions.
This should reduce the number of warnings from GitHub about functionality that they have deprecated and plan to remove.
Marking as draft for now as I will push further changes to address other issues.