Add experimental logs query support#34
Merged
dhedgecock merged 2 commits intomainfrom Aug 7, 2023
Merged
Conversation
dhedgecock
requested review from
bcronin,
brettbuddin,
heidmotron and
jknostman29
bcronin
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds experimental support for logs queries
What needed to change in the code and why?
The preprocessor entry now checks the res for a top level switch between
data.attributes.seriesanddata.attributes.logsto route the res to the correct preprocessor.How did you test this?
Unit test that the top level preprocessor returns the correct data frame shape is added.
Code review notes
The log event object is defined as an object of unknown key:value pairs - this is intended to reflect the non-structured schema of the log event.