Optimize for large bundles with numerous globs#326
Open
snipervld wants to merge 2 commits intoligershark:masterfrom
Open
Optimize for large bundles with numerous globs#326snipervld wants to merge 2 commits intoligershark:masterfrom
snipervld wants to merge 2 commits intoligershark:masterfrom
Conversation
Contributor
|
This should be re-worked to use GlobbingUrlBuilder - It internally uses a Cache and is backed by the full faith, credit and trust of ASP.NET Core :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
Asset.ExpandGlobs{:.c#} doesn't cache results ofprovider.GetAllFiles("/"), so in the following example (simplified example - in the real app, this bundle contains different globs at different nested levels):Asset.ExpandGlobswill get all files 6 times. It can be a problem, if the virtual files hierarchy is huge.This PR caches the results of
provider.GetAllFiles("/")perproviderintoHttpContext.Itemsdictionary.Also, this fixes the case when many complex bundles are located on the same page, e.g.:
Each of them will reuse the cached file hierarchy if possible.
P.S. As you can see, I've tested this with
EnableTagHelperBundling = false.ScriptTagHelperandLinkTagHelpercallAsset.ExpandGlobson each execution, which resulted in 5 seconds of rendering for just the script tags in my app, instead of something like ~0.1 seconds. :)