Fix mutable default arguments and replace assertions with proper exceptions#181
Merged
ClemensSchwarke merged 1 commit intoleggedrobotics:mainfrom Feb 26, 2026
Conversation
…ptions - Replace mutable list default `[256, 256, 256]` with tuple `(256, 256, 256)` in MLPModel, CNNModel, and RNNModel to prevent potential shared state across instances. - Replace `assert` statements used for input validation with `raise ValueError(...)` in MLPModel, CNNModel, and RND, since assertions are silently stripped when running with `python -O`.
ClemensSchwarke
approved these changes
Feb 26, 2026
Collaborator
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[256, 256, 256]with tuples(256, 256, 256)inMLPModel,CNNModel, andRNNModelconstructors to prevent potential shared state across instances.assertstatements used for input validation withraise ValueError(...)inMLPModel._get_obs_dim,CNNModel._get_obs_dim,CNNModel.__init__, andresolve_rnd_config, since assertions are silently stripped when running withpython -O(optimized mode).