Skip to content

fix(prek): run make tc as a repository hook#83

Merged
WH-2099 merged 1 commit intomainfrom
fix/prek-make-tc-hook
Apr 21, 2026
Merged

fix(prek): run make tc as a repository hook#83
WH-2099 merged 1 commit intomainfrom
fix/prek-make-tc-hook

Conversation

@WH-2099
Copy link
Copy Markdown
Member

@WH-2099 WH-2099 commented Apr 21, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Closes #82

Summary

  • configure the local make tc hook as a repository-level prek hook with always_run = true
  • disable filename passing for make tc with pass_filenames = false so make does not receive changed paths as extra targets
  • keep the hook behavior consistent for file-driven invocations and empty file selections
  • validation: make test, make check

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@WH-2099 WH-2099 self-assigned this Apr 21, 2026
@WH-2099 WH-2099 marked this pull request as ready for review April 21, 2026 13:25
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 21, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
@WH-2099 WH-2099 merged commit 36d7f4d into main Apr 21, 2026
5 checks passed
@WH-2099 WH-2099 deleted the fix/prek-make-tc-hook branch April 21, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make tc hook should run as a repository-level prek hook

2 participants