Skip to content

refactor(llm): bundle file saver dependencies#76

Merged
laipz8200 merged 2 commits intomainfrom
fp-llm-file-saver-deps
Apr 21, 2026
Merged

refactor(llm): bundle file saver dependencies#76
laipz8200 merged 2 commits intomainfrom
fp-llm-file-saver-deps

Conversation

@laipz8200
Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Refs #66

Summary

  • add FileSaverDependencies so callers can pass one explicit runtime bundle to FileSaverImpl
  • keep the legacy keyword constructor path while rejecting mixed or incomplete construction
  • add focused file-saver constructor coverage and switch the default-path HTTP client test to the new call site

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@laipz8200 laipz8200 marked this pull request as ready for review April 21, 2026 05:26
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 21, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
@laipz8200 laipz8200 merged commit 990b8c8 into main Apr 21, 2026
5 checks passed
@laipz8200 laipz8200 deleted the fp-llm-file-saver-deps branch April 21, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants