Skip to content

refactor(variable-pool)!: make bootstrap construction explicit#72

Merged
laipz8200 merged 2 commits intomainfrom
fp-variable-pool-constructors
Apr 21, 2026
Merged

refactor(variable-pool)!: make bootstrap construction explicit#72
laipz8200 merged 2 commits intomainfrom
fp-variable-pool-constructors

Conversation

@laipz8200
Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Refs #66

Summary

  • move legacy/bootstrap variable-pool assembly into explicit classmethod constructors
  • keep VariablePool() focused on normalized state and reject legacy bootstrap kwargs with a clear migration path
  • update focused helpers and runtime tests to use the new construction entrypoint

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@laipz8200 laipz8200 changed the title refactor(variable-pool): make bootstrap construction explicit refactor(variable-pool)!: make bootstrap construction explicit Apr 21, 2026
@laipz8200 laipz8200 marked this pull request as ready for review April 21, 2026 05:09
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 21, 2026
@laipz8200 laipz8200 enabled auto-merge (squash) April 21, 2026 05:53
@laipz8200 laipz8200 merged commit dcfd6a6 into main Apr 21, 2026
5 checks passed
@laipz8200 laipz8200 deleted the fp-variable-pool-constructors branch April 21, 2026 08:53
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants