Skip to content

refactor(file): make tool file factory registration explicit#68

Merged
laipz8200 merged 6 commits intomainfrom
fp-tool-file-parser
Apr 21, 2026
Merged

refactor(file): make tool file factory registration explicit#68
laipz8200 merged 6 commits intomainfrom
fp-tool-file-parser

Conversation

@laipz8200
Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Refs #66

Summary

  • Make tool file manager factory registration explicit with a small registry and get, require, and scoped use helpers.
  • Preserve the existing setter as a compatibility wrapper and add focused coverage for the new access patterns.

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@laipz8200 laipz8200 marked this pull request as ready for review April 21, 2026 04:19
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 21, 2026
@laipz8200 laipz8200 enabled auto-merge (squash) April 21, 2026 05:54
Comment thread src/graphon/file/tool_file_parser.py Outdated
@laipz8200 laipz8200 requested a review from 41tair April 21, 2026 10:01
@laipz8200 laipz8200 assigned laipz8200 and 41tair and unassigned laipz8200 Apr 21, 2026
@laipz8200 laipz8200 merged commit 36317e0 into main Apr 21, 2026
5 checks passed
@laipz8200 laipz8200 deleted the fp-tool-file-parser branch April 21, 2026 10:25
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants