Skip to content

refactor(nodes)!: rename typed constructor config to data#48

Merged
WH-2099 merged 3 commits intomainfrom
refactor/nodes-constructor-data
Apr 21, 2026
Merged

refactor(nodes)!: rename typed constructor config to data#48
WH-2099 merged 3 commits intomainfrom
refactor/nodes-constructor-data

Conversation

@WH-2099
Copy link
Copy Markdown
Member

@WH-2099 WH-2099 commented Apr 17, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Closes #47

Summary

This follow-up to #38 / #39 renames the typed node-constructor keyword from config to data now that direct instantiation accepts concrete *NodeData payloads instead of raw {id, data} config objects.

What changed:

  • renamed Node.__init__(..., config=...) to Node.__init__(..., data=...)
  • updated concrete node subclasses to forward data= instead of config=
  • updated direct instantiation call sites in examples and tests
  • left raw graph boundary types such as NodeConfigDict unchanged

Why it changed:

  • config still refers to the outer graph payload in this codebase
  • the constructor now receives the inner typed node data payload
  • nodes that already depend on real *_config collaborators read more clearly after the rename

Developer impact:

  • direct keyword construction now uses data= instead of config=
  • raw graph parsing code that still works with NodeConfigDict is unchanged

Validation:

  • make check
  • uv run pytest tests/graph/test_graph_validation.py tests/http/test_client.py tests/nodes/parameter_extractor/test_prompts.py tests/nodes/variable_assigner/test_v1_node.py tests/nodes/variable_assigner/test_v2_node.py

CLA Assistant has not prompted on this pull request yet.

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@WH-2099 WH-2099 self-assigned this Apr 17, 2026
@WH-2099 WH-2099 marked this pull request as ready for review April 17, 2026 11:17
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 17, 2026
@WH-2099 WH-2099 enabled auto-merge (squash) April 17, 2026 11:17
@WH-2099 WH-2099 force-pushed the refactor/nodes-constructor-data branch from 182ec6d to e2aa881 Compare April 21, 2026 13:15
@WH-2099 WH-2099 merged commit 7d07f66 into main Apr 21, 2026
5 checks passed
@WH-2099 WH-2099 deleted the refactor/nodes-constructor-data branch April 21, 2026 13:33
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename typed node constructor config parameter to data

2 participants