Skip to content

chore: resolve ty diagnostics across runtime and nodes#23

Merged
WH-2099 merged 4 commits intomainfrom
chore/ty
Apr 8, 2026
Merged

chore: resolve ty diagnostics across runtime and nodes#23
WH-2099 merged 4 commits intomainfrom
chore/ty

Conversation

@WH-2099
Copy link
Copy Markdown
Member

@WH-2099 WH-2099 commented Apr 8, 2026

Summary

  • resolve the remaining ty diagnostics across graph runtime, model runtime, nodes, variables, and the associated tests
  • split the cleanup into low-risk/protocol-only fixes first, then handle the remaining path-sensitive diagnostics with explicit narrowing and constructors
  • add a regression test for the intentional array[string] validation error path

Why

uv run ty check was failing on a mix of protocol mismatches, over-narrow annotations, and a handful of code paths where the checker could not prove the existing invariants. This branch makes those invariants explicit without broad runtime rewrites.

Impact

  • ty check is green again
  • make pre stays green after the cleanup
  • invalid array[string] outputs now raise a deliberate OutputValidationError instead of surfacing a raw TypeError
  • the second batch of fixes was reviewed separately for logic-change risk; no material regression risk was identified

Validation

  • make pre
  • env UV_CACHE_DIR=/tmp/uv-cache uv run ty check

Closes #22

@WH-2099 WH-2099 changed the title [codex] resolve ty diagnostics across runtime and nodes resolve ty diagnostics across runtime and nodes Apr 8, 2026
@WH-2099 WH-2099 changed the title resolve ty diagnostics across runtime and nodes chore: resolve ty diagnostics across runtime and nodes Apr 8, 2026
@WH-2099 WH-2099 marked this pull request as ready for review April 8, 2026 09:10
@WH-2099 WH-2099 enabled auto-merge (squash) April 8, 2026 09:10
laipz8200
laipz8200 previously approved these changes Apr 8, 2026
Copy link
Copy Markdown
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost LGTM. Please consider my comments.

Comment thread src/graphon/runtime/graph_runtime_state.py Outdated
Comment thread src/graphon/utils/condition/processor.py
@WH-2099 WH-2099 merged commit a66a8f6 into main Apr 8, 2026
7 checks passed
@WH-2099 WH-2099 deleted the chore/ty branch April 8, 2026 10:27
@WH-2099 WH-2099 self-assigned this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve outstanding ty diagnostics across runtime and nodes

2 participants