Skip to content

chore(ci): move image builds to depot#712

Open
goocarlos wants to merge 1 commit intomainfrom
codex/depot-builds
Open

chore(ci): move image builds to depot#712
goocarlos wants to merge 1 commit intomainfrom
codex/depot-builds

Conversation

@goocarlos
Copy link
Copy Markdown
Member

Moves the daemon image workflow from local Docker builds on the runner to Depot remote container builds.

What changed:

  • added depot.json and set the workflow to use DEPOT_PROJECT_ID
  • switched the build job to depot/setup-action@v1 + depot/build-push-action@v1
  • added permissions.id-token: write for OIDC auth
  • removed runner-local docker build / docker tag / docker push loops
  • switched to digest artifacts plus a manifest-creation step for the final multi-arch tags

Cache strategy:

  • removed GitHub Actions layer cache export/import
  • rely on Depot's native layer cache instead of type=gha

Local developer scripts were not changed.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new depot.json configuration file. The review feedback suggests renaming the id field to project to ensure the project is correctly identified by the Depot CLI and GitHub Actions.

Comment thread depot.json
@@ -0,0 +1 @@
{"id":"smkxz53ddb"}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Depot configuration file should use the key project instead of id. The Depot CLI and associated GitHub Actions look for the project field to identify the target project. Using id may cause the project to be undetected if not otherwise specified in the workflow environment.

Suggested change
{"id":"smkxz53ddb"}
{"project":"smkxz53ddb"}

@fatelei
Copy link
Copy Markdown
Contributor

fatelei commented Apr 29, 2026

rebase main code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants