Skip to content

fix(auth): avoid panic on invalid password hash #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krivahtoo wants to merge 1 commit into from
+10 −1
Closed

fix(auth): avoid panic on invalid password hash #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/server/src/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,13 @@
.to_string()
}

pub fn verify_password(password: &str, hash: &str) -> bool {

Check warning on line 93 in crates/server/src/auth.rs

View workflow job for this annotation

GitHub Actions / Check 

function `verify_password` is never used

Check warning on line 93 in crates/server/src/auth.rs

View workflow job for this annotation

GitHub Actions / Clippy 

function `verify_password` is never used
use argon2::{PasswordHash, PasswordVerifier};

let parsed_hash = PasswordHash::new(hash).expect("Invalid hash format");
let Ok(parsed_hash) = PasswordHash::new(hash) else {
return false;
};

Argon2::default()
.verify_password(password.as_bytes(), &parsed_hash)
.is_ok()
Expand Down Expand Up @@ -170,6 +173,12 @@
assert!(!verify_password(empty_password, &hashed));
}

#[test]
fn test_verify_password_invalid_hash() {
// Invalid hash input should not panic and should return false.
assert!(!verify_password("test_password", "not-a-valid-hash"));
}

#[test]
fn test_auth_error_display() {
let missing_creds = AuthError::MissingCredentials;
Expand Down
Loading