Skip to content

added NetworkError reason and status code#35

Open
arossert wants to merge 2 commits intokonomae:masterfrom
arossert:add_networkerror_information
Open

added NetworkError reason and status code#35
arossert wants to merge 2 commits intokonomae:masterfrom
arossert:add_networkerror_information

Conversation

@arossert
Copy link
Copy Markdown

Adding more information on network errors

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2019

Codecov Report

Merging #35 into master will decrease coverage by 17.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #35       +/-   ##
==========================================
- Coverage   89.86%   72.7%   -17.17%     
==========================================
  Files           9       9               
  Lines         306     381       +75     
==========================================
+ Hits          275     277        +2     
- Misses         31     104       +73
Impacted Files Coverage Δ
lastpass/fetcher.py 60.83% <100%> (-35.22%) ⬇️
lastpass/parser.py 72.02% <0%> (-15.03%) ⬇️
lastpass/vault.py 75.6% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5063911...cd5c8ce. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2019

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@5063911). Learn more about missing BASE report.
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   72.70%           
=========================================
  Files             ?        9           
  Lines             ?      381           
  Branches          ?        0           
=========================================
  Hits              ?      277           
  Misses            ?      104           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants