Skip to content

Commit f3c671b

Browse files
DaanHooglandkishankavala
authored andcommitted
findbugs: repeated condition seems c&p error the tested states sugest that EXPUNGED should be the last one
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes apache#491
1 parent 95c6b3a commit f3c671b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

server/src/com/cloud/storage/VolumeApiServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1212,7 +1212,7 @@ public boolean deleteVolume(long volumeId, Account caller) throws ConcurrentOper
12121212
}
12131213

12141214
try {
1215-
if (volume.getState() != Volume.State.Destroy && volume.getState() != Volume.State.Expunging && volume.getState() != Volume.State.Expunging) {
1215+
if (volume.getState() != Volume.State.Destroy && volume.getState() != Volume.State.Expunging && volume.getState() != Volume.State.Expunged) {
12161216
Long instanceId = volume.getInstanceId();
12171217
if (!volService.destroyVolume(volume.getId())) {
12181218
return false;

0 commit comments

Comments
 (0)