findbugs: decoding String using preferred Charset

DaanHoogland · kishankavala · commit 95c6b3a4ce9a · 2015-06-25T12:15:48.000+05:30
diff --git a/server/src/com/cloud/network/NetworkModelImpl.java b/server/src/com/cloud/network/NetworkModelImpl.java
@@ -2323,7 +2323,7 @@ public List<String[]> generateVmData(String userData, String serviceOffering, St
                     throw new CloudRuntimeException("Unable to get MD5 MessageDigest", e);
                 }
                 md5.reset();
-                md5.update(password.getBytes());
+                md5.update(password.getBytes(StringUtils.getPreferredCharset()));
                 byte[] digest = md5.digest();
                 BigInteger bigInt = new BigInteger(1, digest);
                 String hashtext = bigInt.toString(16);

Original file line number	Diff line number	Diff line change
`@@ -2323,7 +2323,7 @@ public List<String[]> generateVmData(String userData, String serviceOffering, St`
`2323`	`2323`	`throw new CloudRuntimeException("Unable to get MD5 MessageDigest", e);`
`2324`	`2324`	`}`
`2325`	`2325`	`md5.reset();`
`2326`		`- md5.update(password.getBytes());`
	`2326`	`+ md5.update(password.getBytes(StringUtils.getPreferredCharset()));`
`2327`	`2327`	`byte[] digest = md5.digest();`
`2328`	`2328`	`BigInteger bigInt = new BigInteger(1, digest);`
`2329`	`2329`	`String hashtext = bigInt.toString(16);`