Add optional GPG signing status display in commits pane#5376
Open
Xyerophyte wants to merge 1 commit intojesseduffield:masterfrom
Open
Add optional GPG signing status display in commits pane#5376Xyerophyte wants to merge 1 commit intojesseduffield:masterfrom
Xyerophyte wants to merge 1 commit intojesseduffield:masterfrom
Conversation
Add a new gui.showGpgSigningStatus config option that, when enabled, shows GPG signature verification status for each commit in the commits view. Uses git's %G? format placeholder to display colored indicators: green check for valid signatures, red X for bad/revoked, yellow tilde for missing keys, and blue dash for unsigned commits. Disabled by default since GPG verification adds latency to commit loading. Closes jesseduffield#5363 Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Adds an optional gui.showGpgSigningStatus config option that displays a colored GPG signature verification indicator for each commit in the commits view.
Changes:
- New
ShowGpgSigningStatusconfig field (defaultfalse) with schema and docs - Conditional
%G?format in git log and parsing of GPG status field in commit loader - Colored GPG status indicator column in commit presentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/user_config.go | New ShowGpgSigningStatus bool config field |
| pkg/commands/models/commit.go | GpgStatus field added to Commit struct and NewCommitOpts |
| pkg/commands/git_commands/commit_loader.go | Conditional GPG format in log command and parsing of GPG field |
| pkg/gui/presentation/commits.go | Renders colored GPG status indicator column |
| schema-master/config.json | Schema entry for new config option |
| docs-master/Config.md | Documentation for new config option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gui.showGpgSigningStatusconfig option (default:false) that shows GPG signature verification status for each commit in the commits viewcheck- valid signature (G/U)X- bad/revoked/expired signature (B/R/X/Y)~- missing signing key (E)-- unsigned commit (Nor empty)Closes #5363
Example config
Changes
GpgStatusfield toCommitstruct andNewCommitOptsprettyFormatWithGpgconstant using%G?format placeholder; conditionally selects format and parses the GPG field based on configShowGpgSigningStatus booltoGuiConfigwithfalsedefaultTest plan
showGpgSigningStatus: false(default): no change in behavior or performanceshowGpgSigningStatus: true: GPG status column is displayed with colored indicatorsMade with Cursor