fix: treat null timestamp lock files as stale#233
Open
Jah-yee wants to merge 1 commit intojarrodwatts:mainfrom
Open
fix: treat null timestamp lock files as stale#233Jah-yee wants to merge 1 commit intojarrodwatts:mainfrom
Jah-yee wants to merge 1 commit intojarrodwatts:mainfrom
Conversation
Fixes jarrodwatts#220 - 0-byte lock file permanently blocks usage display When a lock file exists but is 0 bytes (created but not written to due to process crash between fs.openSync and fs.writeFileSync), readLockTimestamp returns null. The stale-lock check was: if (lockTimestamp != null && Date.now() - lockTimestamp > CACHE_LOCK_STALE_MS) Since lockTimestamp IS null for 0-byte files, the condition is FALSE and the stale check is skipped entirely. This causes the lock to be treated as 'busy' forever, silently blocking usage display. The fix treats null timestamp (corrupt/empty lock file) as stale, matching the intent of the stale-lock mechanism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220 - 0-byte lock file permanently blocks usage display
When a lock file exists but is 0 bytes (created but not written to
due to process crash between fs.openSync and fs.writeFileSync),
readLockTimestamp returns null.
The stale-lock check was:
if (lockTimestamp != null && Date.now() - lockTimestamp > CACHE_LOCK_STALE_MS)
Since lockTimestamp IS null for 0-byte files, the condition is FALSE
and the stale check is skipped entirely. This causes the lock to be
treated as 'busy' forever, silently blocking usage display.
The fix treats null timestamp (corrupt/empty lock file) as stale,
matching the intent of the stale-lock mechanism.