Tolerate gated screenshot test checks#2822
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
I think this will make the screenshot test fail silently if it breaks for whatever reason, what do you think @richardTingle ? Maybe we need to check for an outcome or something to make sure it is failing due to missing approval. |
|
Not posting the comment isn't a huge deal. The pipeline would still fail, it just wouldn't produce a comment explaining why. But if this is going to happen regularly now pipelines require approval it might be necessary to revisit the auto comment (it may just not be possible anymore). Really the comment was important when the tests were new to explain them, now they're embedded it isn't quite so essential |
makes sense, i think it would be enough to generate an annotation with the same text using https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#setting-an-error-message |
Summary
Reasoning
Fork pull requests can leave the
Build jMonkeyEngineworkflow inaction_requiredbefore any jobs are created. In that case theRun Screenshot Testscheck never exists, but thepull_request_targetcomment workflow still runs and currently fails while waiting for that check.This keeps real screenshot failures working the same way, while avoiding a misleading failed check when there was no screenshot test run to inspect.