Skip to content

feat: provide a default implementation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 1 commit into from
Mar 22, 2023
Merged

feat: provide a default implementation #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions comm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
It also provides a base Comm implementation and a default CommManager for the IPython case.
"""

from .base_comm import CommManager
from .base_comm import BaseComm, CommManager

__version__ = "0.1.2"
__all__ = [
Expand All @@ -20,12 +20,17 @@
_comm_manager = None


class DummyComm(BaseComm):
def publish_msg(self, msg_type, data=None, metadata=None, buffers=None, **keys):
pass


def _create_comm(*args, **kwargs):
"""Create a Comm.

This method is intended to be replaced, so that it returns your Comm instance.
"""
raise NotImplementedError("Cannot ")
return DummyComm(*args, **kwargs)


def _get_comm_manager():
Expand Down