fix: lower Android minSdk and iOS deploymentTarget#8
Open
OS-pedrogustavobilro wants to merge 5 commits intomainfrom
Open
fix: lower Android minSdk and iOS deploymentTarget#8OS-pedrogustavobilro wants to merge 5 commits intomainfrom
OS-pedrogustavobilro wants to merge 5 commits intomainfrom
Conversation
# Conflicts: # android/build.gradle # example-app/ios/App/CapApp-SPM/Package.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower the platform SDK minimums to absolute minimums that the plugin can still work with:
minSdk26, because that's what ML Kit Gen AI SDK requires.Did some tests and everything seems to be working (i.e. no crashes) on devices with older operating system versions (previously unsupported by this PR).
This makes the plugin compatible with all supported versions by MABS on ODC, and most on Capacitor (just needs to bump android minimum by a bit).