[BUG] Unresolved style reference (Could not decode attribute value) (TikTok)

[oSumAtrIX]

Using ApkTool v3.0.1 (which supports SDK 36.1) fails to decode and build the resources of TikTok as a consequence:

I: Decoding value resources...
I: Loading resource table from file: C:\Users\oSumAtrIX\AppData\Local\apktool\framework\1.apk
W: Unresolved style reference: key=ResReference{pkg=ResPackage{id=0x7f, name=com.zhiliaoapp.musically}, id=0x0101069a, type=ref}, value=ResPrimitive{type=0x12, data=0xffffffff}
W: Unresolved style reference: key=ResReference{pkg=ResPackage{id=0x7f, name=com.zhiliaoapp.musically}, id=0x0101069a, type=ref}, value=ResPrimitive{type=0x12, data=0x00000000}
I: Decoding file resources...
W: Unresolved attr reference: ns=, name=, id=0x0101069d
W: Could not decode attribute value: ns=, name=, type=0x12, value=0x00000000

What the decoder produced:

What is expected to be decoded:

https://developer.android.com/reference/android/R.attr#useLocalePreferredLineHeightForMinimum was introduced in API 35

Consequence (obviously related to #1407 but different cause likely):

W: C:\Users\oSumAtrIX\Desktop\com.zhiliaoapp.musically_43.7.3-2024307030_minAPI23(arm64-v8a,armeabi-v7a)(nodpi)_apkmirror.com\res\layout\da2.xml:32: error: not well-formed (invalid token).
W: C:\Users\oSumAtrIX\Desktop\com.zhiliaoapp.musically_43.7.3-2024307030_minAPI23(arm64-v8a,armeabi-v7a)(nodpi)_apkmirror.com\res\layout\da2.xml: error: file failed to compile.

I am not exactly sure why this happens because API 36 is supported, but this attribute is introduced with API 35. Reproduce with https://www.apkmirror.com/apk/tiktok-pte-ltd/tik-tok-including-musical-ly/tiktok-44-7-1-release/tiktok-44-7-1-android-apk-download/

[iBotPeaches]

Hmm odd. I wonder if related to #3533, but that was more namespace prefix stripping and this is more value.

[IgorEisberg]

Nah, it's a common mistake people make.
To OP: Apktool doesn't delete your stored frameworks unless you tell it to do so. When a new framework is added to Apktool, you need to run apktool cf to clear the old one first, then the new one will be extracted.

(I deleted the 50 dex files here for speed)

I: Using Apktool 3.0.1 on com.zhiliaoapp.musically.apk with 8 threads
I: Loading resource table...
I: Decoding value resources...
I: Loading resource table from file: C:\Users\IgorEisberg\AppData\Local\apktool\framework\1.apk
I: Decoding file resources...
I: Generating values XMLs...
I: Decoding AndroidManifest.xml with resources...
I: Copying original files...
I: Copying assets...
I: Copying lib...
I: Copying unknown files...

So, there's no issue here.

[IgorEisberg]

Despite that, rebuilding that APK would be impossible, it has a lot of invalid PNGs (empty files) that aapt2 will reject.

I: Using Apktool 3.0.1 on com.zhiliaoapp.musically.apk with 8 threads
I: Building resources with aapt2...
W: .\res\drawable-xxhdpi\l4.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\l4.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\l5.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\l5.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\l6.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\l6.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\l9.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\l9.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\l_.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\l_.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\lb.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\lb.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\ld.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\ld.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\le.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\le.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\lf.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\lf.png: error: file failed to compile.
W: .\res\drawable-xxhdpi\lg.png: error: failed to read PNG signature: file does not start with PNG signature.
W: .\res\drawable-xxhdpi\lg.png: error: file failed to compile.
Exception in thread "main" brut.androlib.exceptions.AndrolibException: brut.common.BrutException: Execution failed (exit code = 1): [C:\Users\IgorEisberg\AppData\Local\Temp\aapt2_2391265988851707150431022625619837043.tmp, compile, --dir, .\res, --legacy, -o, .\build\resources.zip]
        at brut.androlib.res.AaptInvoker.invoke(SourceFile:90)
        at brut.androlib.ApkBuilder.buildResources(SourceFile:357)
        at brut.apktool.Main.main(SourceFile:92)
Caused by: brut.common.BrutException: Execution failed (exit code = 1): [C:\Users\IgorEisberg\AppData\Local\Temp\aapt2_2391265988851707150431022625619837043.tmp, compile, --dir, .\res, --legacy, -o, .\build\resources.zip]
        at brut.util.OS.exec(SourceFile:147)
        at brut.androlib.res.AaptInvoker.invoke(SourceFile:87)
        ... 2 more

Also, with the latest commit you'll see a lot of broken references to stripped resources:

I: Decoding file resources...
W: Unresolved resource reference: ResReference{pkg=ResPackage{id=0x7f, name=com.zhiliaoapp.musically}, id=0x7f133217, type=ref}
W: Unresolved resource reference: ResReference{pkg=ResPackage{id=0x7f, name=com.zhiliaoapp.musically}, id=0x7f13673f, type=ref}
W: Unresolved resource reference: ResReference{pkg=ResPackage{id=0x7f, name=com.zhiliaoapp.musically}, id=0x7f13673f, type=ref}
...

Also, the APK has multiple packages (merged dynamic feature modules using bundletool, which is different than split config APKs because each has a different package ID):

0x50: com.zhiliaoapp.musically.df_live_cas
0x53: com.zhiliaoapp.musically.df_social_fi
0x5b: com.zhiliaoapp.musically.df_ship
0x5c: com.zhiliaoapp.musically.df_wallpaper_main
0x60: com.zhiliaoapp.musically.df_music_dsp
0x74: com.zhiliaoapp.musically.df_pipo_external_payments
0x75: com.zhiliaoapp.musically.df_ccdc_impl_ocr
0x7c: com.zhiliaoapp.musically.df_im_bootfinish
0x7e: com.zhiliaoapp.musically.df_search_biz
0x7f: com.zhiliaoapp.musically

So you won't be able to recreate the standalone APK properly anyway, and even if you work with the bundle variant (*.apkm) you won't have much luck either due to the stripped resources and invalid PNGs.

[rundexz]

Hello. Are there any plans to resolve this issue? I have faced a similar issue with PNG files. I can view the PNG files though. I am not sure if they are regarded as invalid when I can view them or not.

[IgorEisberg]

Hello. Are there any plans to resolve this issue? I have faced a similar issue with PNG files. I can view the PNG files though. I am not sure if they are regarded as invalid when I can view them or not.

You "can view the PNG files" that are empty (0 bytes)? I find it hard to believe.

[rundexz]

@IgorEisberg Thank you for the reply. I was actually referring to a different apk. Upon attempting to recompile (using APK Editor Studio which internally uses apktool)) I get the messages regarding the PNG files. I went to few of the PNG files where issues were reported and I was able to open them with images viewer. Here is the apk I am referring to. File will be removed in 5 days:

https://uploadnow.io/f/8shcPmg

[IgorEisberg]

@IgorEisberg Thank you for the reply. I was actually referring to a different apk. Upon attempting to recompile (using APK Editor Studio which internally uses apktool)) I get the messages regarding the PNG files. I went to few of the PNG files where issues were reported and I was able to open them with images viewer. Here is the apk I am referring to. File will be removed in 5 days:

https://uploadnow.io/f/8shcPmg

I see. It's kind of a different issue. It's not empty in that APK's case, it's simply not an actual PNG.

D: Decoding file r/n/ac4.png to res/drawable-xhdpi/APKTOOL_RENAMED_0x7f080584.png

When you examine that file with a hex editor, it's not a PNG, it's a JPEG (has JFIF in signature).
Apktool doesn't have any MIME/signature detection, it keeps whichever extension the file has.
You can just rename the extension of such files from png to jpg and it'll compile fine.
This is the only image with incorrect extension in that APK.

I: Using Apktool 3.0.2 on t.apk with 8 threads
I: Smaling smali_classes2 folder into classes2.dex...
I: Smaling smali_classes5 folder into classes5.dex...
I: Smaling smali_classes4 folder into classes4.dex...
I: Smaling smali folder into classes.dex...
I: Smaling smali_classes3 folder into classes3.dex...
I: Smaling smali_classes6 folder into classes6.dex...
I: Building resources with aapt2...
I: Building apk file...
I: Importing assets...
I: Importing lib...
I: Importing unknown files...
I: Built apk into: .\dist\t.apk

[rundexz]

@iBotPeaches Thank you for taking the time to examine the issue. I was not completely sure what you meant by renaming the file extension. So, I did a simple rename of the extension for that one file from .png to .jpg and also tried converting the image with wrong extension into png and kept the file extension as without renaming into .jpg. I used the apktool to compile the apk and both of those tricks helped me create the apk file without issues. Though, the resulting apk file cannot be installed. When I install it it says app not installed. Note that I originally used the original 2.x version of apktool which is included in APK Editor Studio and when I tried both of those solutions I had further errors connected to an xml file. So, I went and grabbed the latest 3.x jar which was released yesterday and added it for APK Editor Studio to use. Then, I disabled AAPT2 option in APK Editor Studio settings (because --aap2 argument is not available in 3.x). Then, saved the apk. I actually had issues with file locking so I grabbed the command used by APK Editor Studio and killed the APK Editor Studio exe then used the command to create the apk file. Then, I was able to create it. Here is the command which I used

java -jar "C:/Program Files/APK Editor Studio/tools/apktool.jar" build "C:\Program Files\APK Editor Studio\data\temp\apk\{d057c423-dbca-4bf7-a6f0-b22e70c7fbe7}" --output C:/Downloads/t2.apk --force --frame-path "C:/Program Files/APK Editor Studio/data/frameworks"

[IgorEisberg]

I don't know anything about APK Editor Studio. All I said was to decode the APK and then rename res/drawable-xhdpi/APKTOOL_RENAMED_0x7f080584.png in the output from ".png" to ".jpg", that it...

[rundexz]

Thanks @IgorEisberg Yeah. I renamed and did the conversion as mentioned which both resulted in creation of an apk file. Sadly the apk cannot be installed at all. When you try to install it you get "App not installed" If you have a solution let me know. Thanks in all cases.

P.S. I actually used apktool directly for creating the apk file using the command above.

[IgorEisberg]

Thanks @IgorEisberg Yeah. I renamed and did the conversion as mentioned which both resulted in creation of an apk file. Sadly the apk cannot be installed at all. When you try to install it you get "App not installed" If you have a solution let me know. Thanks in all cases.

P.S. I actually used apktool directly for creating the apk file using the command above.

Did you sign it?...

[rundexz]

Thank you. That was it. I actually do stuff with APK Editor Studio which does all that automatically. Now, I went and have done it manually. Everything works.