新增长图插件，将本子合并为长图#294
Conversation
WalkthroughThe changes introduce a new class Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/jmcomic/jm_plugin.py (1 hunks)
🧰 Additional context used
🪛 Ruff
src/jmcomic/jm_plugin.py
806-806:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
807-807:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
815-815:
jm_logmay be undefined, or defined from star imports(F405)
818-818:
PIL.Imageimported but unused; consider usingimportlib.util.find_specto test for availability(F401)
829-829:
DirRulemay be undefined, or defined from star imports(F405)
841-841:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
841-841:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
850-850:
files_of_dirmay be undefined, or defined from star imports(F405)
875-875:
fix_filepathmay be undefined, or defined from star imports(F405)
876-876:
mkdir_if_not_existsmay be undefined, or defined from star imports(F405)
| images[i] = img.resize((min_img_width, int(img.height * min_img_width / img.width)), | ||
| Image.Resampling.LANCZOS) |
There was a problem hiding this comment.
Ensure compatibility of Image.Resampling.LANCZOS with different Pillow versions
The use of Image.Resampling.LANCZOS requires Pillow version 9.1.0 or newer. In earlier versions, you should use Image.LANCZOS. To maintain compatibility, consider handling this with a fallback.
Modify the code as follows:
from PIL import Image
try:
resample_method = Image.Resampling.LANCZOS
except AttributeError:
resample_method = Image.LANCZOS
# Use resample_method in resize
images[i] = img.resize(
(min_img_width, int(img.height * min_img_width / img.width)),
resample=resample_method
)There was a problem hiding this comment.
@BrandenXia Great! I'm glad the issue has been fixed.
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
src/jmcomic/jm_plugin.py (2)
818-818: Remove unused import ofPIL.ImageThe import statement
from PIL import Imagewithin thetryblock is unused and redundant since you importImageagain later in the code. Removing this import can improve code clarity.Apply this change:
try: - from PIL import Image except ImportError: self.warning_lib_not_install('PIL') return🧰 Tools
🪛 Ruff
818-818:
PIL.Imageimported but unused; consider usingimportlib.util.find_specto test for availability(F401)
875-875: Avoid using list comprehension for side effectsUsing list comprehensions for side effects is discouraged as it creates an unnecessary list and can be less readable. Use a simple
forloop instead to close the images.Apply this change:
- [img.close() for img in images] + for img in images: + img.close()
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/jmcomic/jm_plugin.py (1 hunks)
🧰 Additional context used
🪛 Ruff
src/jmcomic/jm_plugin.py
806-806:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
807-807:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
815-815:
jm_logmay be undefined, or defined from star imports(F405)
818-818:
PIL.Imageimported but unused; consider usingimportlib.util.find_specto test for availability(F401)
829-829:
DirRulemay be undefined, or defined from star imports(F405)
841-841:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
841-841:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
850-850:
files_of_dirmay be undefined, or defined from star imports(F405)
881-881:
fix_filepathmay be undefined, or defined from star imports(F405)
882-882:
mkdir_if_not_existsmay be undefined, or defined from star imports(F405)
🔇 Additional comments (6)
src/jmcomic/jm_plugin.py (6)
806-807: [Duplicate Comment] Explicitly importJmPhotoDetailandJmAlbumDetail🧰 Tools
🪛 Ruff
806-806:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
807-807:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
815-815: [Duplicate Comment] Useself.loginstead ofjm_log🧰 Tools
🪛 Ruff
815-815:
jm_logmay be undefined, or defined from star imports(F405)
829-829: [Duplicate Comment] Explicitly importDirRule🧰 Tools
🪛 Ruff
829-829:
DirRulemay be undefined, or defined from star imports(F405)
841-841: [Duplicate Comment] Explicitly importJmAlbumDetailandJmPhotoDetail🧰 Tools
🪛 Ruff
841-841:
JmAlbumDetailmay be undefined, or defined from star imports(F405)
841-841:
JmPhotoDetailmay be undefined, or defined from star imports(F405)
850-850: [Duplicate Comment] Explicitly importfiles_of_dir🧰 Tools
🪛 Ruff
850-850:
files_of_dirmay be undefined, or defined from star imports(F405)
881-882: [Duplicate Comment] Explicitly importfix_filepathandmkdir_if_not_exists🧰 Tools
🪛 Ruff
881-881:
fix_filepathmay be undefined, or defined from star imports(F405)
882-882:
mkdir_if_not_existsmay be undefined, or defined from star imports(F405)
2 participants
Summary by CodeRabbit
New Features
LongImgPluginfor creating long images by combining multiple photos vertically.Bug Fixes
PILlibrary to prevent processing errors.