Conversation
Contributor
Vercel Previews Deployed
|
rmainwork
force-pushed
the
rm/global-partials
branch
3 times, most recently
from
cf5a50b to
9633240
Compare
rmainwork
force-pushed
the
rm/global-partials
branch
from
9633240 to
5d7b951
Compare
rmainwork
force-pushed
the
rm/global-partials
branch
2 times, most recently
from
115f1cc to
5c0186f
Compare
LeahMarieBush
approved these changes
Feb 20, 2026
Contributor
LeahMarieBush
left a comment
LeahMarieBush
left a comment
There was a problem hiding this comment.
LGTM! Don't forget to remove the examples 🚢
Contributor
Author
|
Thanks @LeahMarieBush! Good call out on remembering to remove the examples! I've also added a test to fully capture the inclusion of content from |
yhyakuna
approved these changes
Feb 25, 2026
github-actions
Bot
removed
Vault
Some sample content was added ine5db0801b27f81c6597985c34f8099e88c37ee59 to demonstrate the global partials functionality. However, this needs to be removed prior to merge Reverts e5db080
rmainwork
force-pushed
the
rm/global-partials
branch
from
e38c6e0 to
59d702b
Compare
If a global partial that was included with the global path alias is missing, we should throw - not fall through to any local partial that may or may not have the same name...
Contributor
LeahMarieBush
left a comment
LeahMarieBush
left a comment
There was a problem hiding this comment.
I left a few minor comments but after those are resolved this will be good to go!
- Updated README to reflect the `@global/` namespace - Also added example combining local and global partials
Whitespace changes were accidentally introduced from `main` in testing. Restore these to dismiss unnecessary CODEOWNERS reviews
Contributor
Author
|
@LeahMarieBush sweet - when the build finishes I'll merge then |
victorr
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Global partials POC Implement basic global partials POC support * Create sample content Create example content demonstrating global partial functionality * Ignore directories not listed in PRODUCT_CONFIG * Move global partials dir to /content/global/partials * Test global partials inclusion using a mocked fs Adds a test verifying that @include directives resolve partials from content/global/partials. The filesystem is mocked with memfs so the test does not depend on real content in that directory — important because the functionality under test is path-dependent, and placing fixture data in the real content tree would couple tests to production content(and also clutter the content directory with junk test data). * Remove global partials sample content Some sample content was added ine5db0801b27f81c6597985c34f8099e88c37ee59 to demonstrate the global partials functionality. However, this needs to be removed prior to merge Reverts e5db080 * Compile prebuild * Add missing test fixture * Create global path alias * Don't fall through to local partials If a global partial that was included with the global path alias is missing, we should throw - not fall through to any local partial that may or may not have the same name... * Updated README - Updated README to reflect the `@global/` namespace - Also added example combining local and global partials * Restore accidental whitespace changes Whitespace changes were accidentally introduced from `main` in testing. Restore these to dismiss unnecessary CODEOWNERS reviews
hellobontempo
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Global partials POC Implement basic global partials POC support * Create sample content Create example content demonstrating global partial functionality * Ignore directories not listed in PRODUCT_CONFIG * Move global partials dir to /content/global/partials * Test global partials inclusion using a mocked fs Adds a test verifying that @include directives resolve partials from content/global/partials. The filesystem is mocked with memfs so the test does not depend on real content in that directory — important because the functionality under test is path-dependent, and placing fixture data in the real content tree would couple tests to production content(and also clutter the content directory with junk test data). * Remove global partials sample content Some sample content was added ine5db0801b27f81c6597985c34f8099e88c37ee59 to demonstrate the global partials functionality. However, this needs to be removed prior to merge Reverts e5db080 * Compile prebuild * Add missing test fixture * Create global path alias * Don't fall through to local partials If a global partial that was included with the global path alias is missing, we should throw - not fall through to any local partial that may or may not have the same name... * Updated README - Updated README to reflect the `@global/` namespace - Also added example combining local and global partials * Restore accidental whitespace changes Whitespace changes were accidentally introduced from `main` in testing. Restore these to dismiss unnecessary CODEOWNERS reviews
rmainwork
added a commit
that referenced
this pull request
Mar 13, 2026
Compiled prebuild scripts were missed from the original PR (#1856) meaning that users who depended on global partials were unable to use them
Merged
rmainwork
added a commit
that referenced
this pull request
Mar 13, 2026
* Prebuild Scripts Compiled prebuild scripts were missed from the original PR (#1856) meaning that users who depended on global partials were unable to use them * Remove console logs from prebuild script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds global partials support under
/content/partials. Partials created here can be included between products (as demonstrated below between Consul and Boundary). A sample partial was added in 5d7b951 for testing purposes and included in pages for Boundary and Consul. This will be removed before merging.