Conversation
🦋 Changeset detectedLatest commit: d378b49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
|
|
||
| // allow usage of <= sign | ||
| safe = safe.replace('<=', '\\<=') |
There was a problem hiding this comment.
unescaping some of these seems quite dangerous. If it works it works, but especially _, *, and [ will interfere at some point
There was a problem hiding this comment.
Potentially, yeah. It seems safe as they are in text nodes at this point, so we know they aren't part of a pair elsewhere in the tree, but I agree it might not hold up for everything. Testing out the script on our docs sites now, we'll see if we run into any issues 🤞
|
|
||
| console.log(entry.fullPath) | ||
|
|
||
| const fileContents = await fs.promises.readFile(entry.fullPath, 'utf-8') |
There was a problem hiding this comment.
I’d recommend remark-frontmatter / mdast-util-frontmatter.
Also: use remark-gfm if you use GFM features!
Having those nodes in the tree for proper warning locations and proper serialization might help!
📦 Canary Packages PublishedLatest commit: d378b49 Published 1 packages@hashicorp/mdx-v2-migrate@0.1.0-canary-20211030174638 |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Bryce Kalow seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
4 participants
🎟️ Asana Task
Description
Adding a new package containing the custom configured remark compiler which migrates our MDX v1 source to be MDX v2 compat.
PR Checklist 🚀