[Project Solar / Phase 1 / Components] DialogPrimitive/Modal/Flyout carbonization#3645
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@dchyun probably I could rebase this branch on yours, or viceversa, so we can see the overall effect of both carbonizations (it's used also in the |
c3ba6a1 to
2abc5d1
Compare
2abc5d1 to
b50ac52
Compare
51554b2 to
6d1e9e8
Compare
b50ac52 to
dfec8eb
Compare
6d1e9e8 to
f4f830d
Compare
dfec8eb to
2ee74fb
Compare
2ee74fb to
9afb23f
Compare
f4f830d to
78e8666
Compare
9afb23f to
4789032
Compare
jorytindall
left a comment
There was a problem hiding this comment.
This is looking largely pretty good to me, but I have a few questions:
- What is that comparison component on the Flyout showcase page withe the borders in the Header/Footer? Is that something coming from Carbon? I guess it's making me question some of my strategy of trying to kind of mimic the Modal for all of the styling
- I thought the Dismiss Button was already migrated, but it doesn't look like any of the interactive states are working to test. Actually looking this it looks like pointer events are just disabled for the showcase pages, is this right?
- I think the Tagline has the incorrect font-size, what I have is 12px
@jorytindall it's the
If you refer to the horizontal dividers it's because they have some animations/special transitions: see this example and scroll the content of the sidepane/flyout https://ibm-products-web-components.carbondesignsystem.com/?path=/story/components-sidepanel--with-static-title
Yes I have disabled the "click" otherwise it would remove the Modal/Flyout from the page if one accidentally (or intentionally) clicks it :)
Fixed. I have now added component-level tokens for the |
jorytindall
left a comment
There was a problem hiding this comment.
Thanks for the context on this, following up on a few things:
- Horizontal dividers in the Carbon SidePanel: looking at the examples you shared, these only seem to appear when the height of the content is greater than the height of the viewport and the content scrolls. I'm not going to change anything in the component for now
- Dismiss buttons: sounds good, that's what I thought!
- Tagline: I've also updated the DialogPrimitive to map to CDS
text-primaryinstead of the default mapping for faint, that's a nice catch.
…oent from IBM 4 Products
…ents until they’re ready/defined
…lue (per designers’ decision)
… follow latest design decisions - remove colors in “carbon” mode for the Modal headers - reduce vertical padding of the body in “carbon” mode
…o `DialogPrimitive` (#3748)
📌 Summary
This PR intends to finalize the "carbonization" of the
DialogPrimitive,Modal, andFlyoutcomponents.🛠️ Detailed description
In this PR I have:
utilities/dialog-primitiveandcomponents/flyoutcomponents/modalwas done during the dry-run phasedialog-primitiveandmodalDialogPrimitive,ModalandFlyoutcomponentsDismissButtonposition when carbonized (following [Project Solar / Phase 1 / Components]DismissButtoncarbonization #3665)DialogPrimitiveto align with most recent Figma variables for the componentFlyoutby using equivalent web component (SidePanel from IBM 4 Products)👀 Previews:
🔗 External links
Jira tickets:
Figma file: https://www.figma.com/design/GWMDKHuGr98DFxSptH6vgj/-LJ--Token-Migration
👀 Component checklist
DialogPrimitiveandModalscreenshots are due to the fact that we added a 1px transparent border to the dialog primitive, which slightly shifts the layout of the element; this is not an issue in production code, since the component in horizontally/vertically centered in the screen💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.