Allow percentage as a valid unit for height#748
Closed
luckylooke wants to merge 2 commits intogridstack:developfrom
Closed
Allow percentage as a valid unit for height#748luckylooke wants to merge 2 commits intogridstack:developfrom
luckylooke wants to merge 2 commits intogridstack:developfrom
Conversation
Member
|
This seems like it would cause problems in some places. No? I know that height in percentage is really funky across different browsers. |
Contributor
Author
|
Maybe, but should be let on user to decide, not all percentage cases are so funky ;) We are using flex and we did not catch any problems with percentage heights yet. :) |
Member
|
actually % height makes perfect sense for nested grids where as fixed pixel doesn't! |
3 tasks
Member
|
using #1093 as I wasn't able to merge it for some reason... thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
percentage is also valid css unit for height