Skip to content

Allow percentage as a valid unit for height#748

Closed
luckylooke wants to merge 2 commits intogridstack:developfrom
luckylooke:patch-2
Closed

Allow percentage as a valid unit for height#748
luckylooke wants to merge 2 commits intogridstack:developfrom
luckylooke:patch-2

Conversation

@luckylooke
Copy link
Copy Markdown
Contributor

percentage is also valid css unit for height

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 70.525% when pulling 86ce62a on luckylooke:patch-2 into fa4f2d0 on troolee:develop.

@radiolips
Copy link
Copy Markdown
Member

This seems like it would cause problems in some places. No? I know that height in percentage is really funky across different browsers.

@luckylooke
Copy link
Copy Markdown
Contributor Author

Maybe, but should be let on user to decide, not all percentage cases are so funky ;) We are using flex and we did not catch any problems with percentage heights yet. :)

@adumesny
Copy link
Copy Markdown
Member

adumesny commented Mar 29, 2019

actually % height makes perfect sense for nested grids where as fixed pixel doesn't!
I mean if I have a parent cell (which user can resize at will) then children probably have to take entire height and be % based. I doubt the code would allow you to add/remove rows based on drag gesture though...

@adumesny
Copy link
Copy Markdown
Member

adumesny commented Dec 16, 2019

using #1093 as I wasn't able to merge it for some reason... thanks for the fix!

@adumesny adumesny closed this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants