RemoveWidget() now call _triggerChangeEvent()#1147
Merged
adumesny merged 2 commits intogridstack:developfrom Feb 16, 2020
adumesny:develop
Merged
RemoveWidget() now call _triggerChangeEvent()#1147adumesny merged 2 commits intogridstack:developfrom adumesny:develop
adumesny merged 2 commits intogridstack:developfrom
adumesny:develop
Conversation
added 2 commits
February 15, 2020 17:13
* fix for #1142 * make sure to call any other change when adding/removing widgets * this right now can call extra uncessary change CB at times, but better than not calling on nodes that changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix for RemoveWidget() doesn't also trigger change events when it should #1142
make sure to call
changeevents (for other nodes) when adding/removing widgetsthis right now can call extra unecessary change CB at times, but better than not calling on nodes that changed. Will optimize next..
introduced when I commented _triggerChangeEvent() calls in fixed callbacks types #1096
Checklist
yarn test)