Skip to content

chore(dev-deps): upgrade babel, jest, eslint#1470

Merged
acao merged 8 commits intographql:masterfrom
acao:chore/upgrade-babel
Apr 9, 2020
Merged

chore(dev-deps): upgrade babel, jest, eslint#1470
acao merged 8 commits intographql:masterfrom
acao:chore/upgrade-babel

Conversation

@acao
Copy link
Copy Markdown
Member

@acao acao commented Apr 9, 2020

I think this might nip a few upstream babel issues I've started seeing in CI (github actions, netlify). I've disabled dependabot except for security updates, because of noise in the git log more than anything.

contains:

  • changes from prettier 1.x to 2.x - arrow parenthesis is by default now so I disabled that in .prettierrc, however space between function ( as such is now required. Prettier migration notes
  • upgrade babel and dependencies - to fix some build issues seen in GA and netlify
  • add prettier-ignore to markdown files where we tend to have issues (where users open PRs via github UI especially)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2020

Codecov Report

Merging #1470 into master will not change coverage by %.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1470   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files          60       60           
  Lines        3023     3023           
  Branches      806      796   -10     
=======================================
  Hits         1783     1783           
  Misses       1194     1194           
  Partials       46       46           
Impacted Files Coverage Δ
packages/graphiql/src/components/ImagePreview.tsx 2.85% <0.00%> (ø)
packages/graphiql/src/utility/debounce.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f9af6...b597260. Read the comment docs.

@acao acao force-pushed the chore/upgrade-babel branch from 307e77d to e4ef4fa Compare April 9, 2020 12:55
@acao acao merged commit 0013078 into graphql:master Apr 9, 2020
@acao acao deleted the chore/upgrade-babel branch April 9, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant