Skip to content

Hookup Completions with Monaco Editor#1460

Closed
rebornix wants to merge 1 commit intographql:feat/monaco-servicefrom
rebornix:rebornix/monaco-completions
Closed

Hookup Completions with Monaco Editor#1460
rebornix wants to merge 1 commit intographql:feat/monaco-servicefrom
rebornix:rebornix/monaco-completions

Conversation

@rebornix
Copy link
Copy Markdown
Contributor

@rebornix rebornix commented Apr 4, 2020

The completions items from the language service are now returned back to the editor.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2020

Codecov Report

Merging #1460 into feat/monaco-service will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/monaco-service    #1460      +/-   ##
=======================================================
- Coverage                57.87%   57.82%   -0.06%     
=======================================================
  Files                       63       63              
  Lines                     3091     3094       +3     
  Branches                   819      820       +1     
=======================================================
  Hits                      1789     1789              
- Misses                    1256     1259       +3     
  Partials                    46       46              
Impacted Files Coverage Δ
packages/monaco-graphql/src/graphql.worker.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3f8ce...117db54. Read the comment docs.

@acao
Copy link
Copy Markdown
Member

acao commented Apr 4, 2020

already in the new PR! #1459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants