Actually run the tests in python 3.12 and 3.13 and remove snapshottest dependency#1572
Actually run the tests in python 3.12 and 3.13 and remove snapshottest dependency#1572erikwrede merged 5 commits intographql-python:masterfrom
snapshottest dependency#1572Conversation
|
From what I can tell there are at least two open pull requests in |
so that the tests pass in 3.12 and 3.13 again
because the snapshottest package doesn't work on Python 3.12 and above
snapshottest dependency
|
I also dropped the |
|
I did notice that tests on Python 3.12 are not working as expected, but hadn't chance to dig into it. Thank you 🙏 I agree that Graphene needs to drop snapshottest as it's failing to work on Python 3.12 and above. I'll try to take time and review your changes. |
|
@erikwrede ping? |
erikwrede
left a comment
There was a problem hiding this comment.
Sorry for the delay, currently really busy in my day-to-day.
Thanks for picking this up and pinging me!
|
Seems like we have some test failures in 3.13. Will investigate later. |
|
looks like the |
|
Thank you! |
I noticed that 614449e (PR #1550) introduced an invalid tox environment:
py12instead ofpy312. This mistake was later repeated in 6834385 (PR #1561):py13instead ofpy313.On my machine,
tox listoutputs:And
tox rundoesn't run any tests in thepy312andpy313environments. This is also true in the Github workflows.For example, in this "successful" run in the

py312environment from 2024-07-01 tox only runspip install .[test]and nothing else.This looks very different from this run in the

py311environment, which also runspytest:This PR actually runs the tests in the
py312andpy313and drops thesnapshottestdependency (which was only used in the example tests) so that the tests also work in Python 3.12 and above. This is necessary becausesnapshottest(which appears dead) is using Python'simpmodule, which has been deprected since 3.4 and was removed in 3.12.