Default enum description to "An enumeration."#1502
Merged
erikwrede merged 5 commits intographql-python:masterfrom May 25, 2023
Merged
Default enum description to "An enumeration."#1502erikwrede merged 5 commits intographql-python:masterfrom
erikwrede merged 5 commits intographql-python:masterfrom
Conversation
default to this string, which is used in many tests, is causing
sjdemartini
reviewed
May 4, 2023
Member
|
Thanks for the PR @firaskafri 🙂 |
Contributor
Author
Hi @erikwrede ! Just added two tests to address these cases! |
erikwrede
previously approved these changes
May 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1502 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 51 51
Lines 1750 1750
=======================================
Hits 1680 1680
Misses 70 70
☔ View full report in Codecov by Sentry. |
erikwrede
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default enum description to "An enumeration." string as opposed to trying to read
enum.__doc__as it appears to be not set to default enum class doc in python 3.11