Skip to content

feat: add ability to provide a type name to enum when using from_enum#1430

Merged
tcleonard merged 1 commit intographql-python:masterfrom
loft-orbital:feat/enable-to-provide-enum-name
Jun 27, 2022
Merged

feat: add ability to provide a type name to enum when using from_enum#1430
tcleonard merged 1 commit intographql-python:masterfrom
loft-orbital:feat/enable-to-provide-enum-name

Conversation

@tcleonard
Copy link
Collaborator

No description provided.

@tcleonard tcleonard force-pushed the feat/enable-to-provide-enum-name branch from aad8405 to 8f6a8f9 Compare June 24, 2022 16:18
@tcleonard tcleonard requested a review from erikwrede June 24, 2022 16:19
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Next step should be to add some central registry to check for naming collisions and invariant collisions. See #1418

@tcleonard tcleonard merged commit 72c2fd5 into graphql-python:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants